[Date Picker] fix: moment date conversion for Date Picker in native #15033

Prince-Mendiratta · 2023-02-10T08:43:20Z

Details

The main problem that we are trying to solve in this issue is that for the date picker in Date of Birth under the Personal Details component, the selected date is not acknowledged and shows the error Date Invalid even when the date is valid in native devices on iOS and android. Moreover, the possible dates shown to the user are not consistent across platforms.

Fixed Issues

$ #14936
PROPOSAL: #14936 (comment)

Tests

Login to newDot
Click on settings.
Click on Profile > Personal Details > Date of birth.
Open the date picker.
Click on save without entering any date. Ensure that an error is shown, namely Please enter a valid date.
Enter a date in the future. Ensure that an error is shown, namely Date should be before 20xx-xx-xx.
Enter a date before the date shown in the error above. Ensure that the date is entered correctly and no errors are shown.
After saving the date, Ensure that the saved date is shown in the Date of Birth section in the Personal Details.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Login to newDot
Click on settings.
Click on Profile > Personal Details > Date of birth.
Open the date picker.
Click on save without entering any date. Ensure that an error is shown, namely Please enter a valid date.
Enter a date in the future. Ensure that an error is shown, namely Date should be before 20xx-xx-xx.
Enter a date before the date shown in the error above. Ensure that the date is entered correctly and no errors are shown.
After saving the date, Ensure that the saved date is shown in the Date of Birth section in the Personal Details.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web - Chrome

web-chrome.mp4

Web - Safari

web-safari.mp4

Mobile Web - Chrome

mWeb-Chrome.mp4

Mobile Web - Safari

mWeb-safari.mp4

Desktop

desktop.mp4

iOS

iOS.mp4

Android

android.mp4

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

MelvinBot · 2023-02-10T08:43:24Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

MelvinBot · 2023-02-10T08:43:27Z

@Beamanator @Santhosh-Sellavel One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Prince-Mendiratta · 2023-02-10T08:45:23Z

src/CONST.js

@@ -65,6 +65,7 @@ const CONST = {
        MOMENT_FORMAT_STRING: 'YYYY-MM-DD',
        UNIX_EPOCH: '1970-01-01 00:00:00.000',
        MAX_DATE: '9999-12-31',
+        MIN_DATE: '0001-01-01',


Set this like this because in web, this is the earliest date by default.

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta · 2023-02-13T14:17:10Z

gentle bump @Santhosh-Sellavel

src/pages/ReimbursementAccount/CompanyStep.js

src/pages/ReimbursementAccount/RequestorStep.js

Santhosh-Sellavel · 2023-02-13T16:34:33Z

@Prince-Mendiratta

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta · 2023-02-13T16:48:06Z

@Santhosh-Sellavel pushed!

Beamanator · 2023-02-13T17:23:04Z

@Prince-Mendiratta will you please update the PR title to be more useful? It's best if it describes exactly what you're doing in this PR

Santhosh-Sellavel · 2023-02-13T22:33:28Z

Android calendar is not persisted for previously selected months if before 1900. Check month is shown as January 1900

Screen_Recording_20230214_035805_New.Expensify.mp4

Santhosh-Sellavel · 2023-02-13T22:36:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-02-14.at.4.06.56.AM.mov

Mobile Web - Chrome

Screen_Recording_20230214_035903_Chrome.mp4

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.-.2023-02-14.at.04.05.25.mp4

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-02-14.at.04.04.49.mp4

Android

Screen_Recording_20230214_035805_New.Expensify.mp4

Santhosh-Sellavel · 2023-02-13T22:40:37Z

Will continue tomorrow

Santhosh-Sellavel · 2023-02-15T00:48:36Z

@Prince-Mendiratta

Any thoughts on this #15033 (comment)?

CC: @Beamanator

Beamanator · 2023-02-15T08:47:04Z

@Santhosh-Sellavel

Android calendar is not persisted for previously selected months if before 1900. Check month is shown as January 1900

Interesting find - I think this is fine for now, since we're actually building our own cross-platform Date Picker at the moment, so this shouldn't be a problem in the near future 👍

Prince-Mendiratta · 2023-02-15T09:43:53Z

@Santhosh-Sellavel I'm not too sure about that behaviour either, wasn't able to find any relevant resource online ;-;

Prince-Mendiratta · 2023-02-16T13:49:16Z

bump @Santhosh-Sellavel, I think this should be good to merge?

Santhosh-Sellavel · 2023-02-16T19:05:20Z

@Beamanator
This is not from this PR should we do something about it though?
Steps

Select an invalid to submit error shown
Exit the DOB page
Open again DOB page again

Values should not be persisted right?
https://user-images.githubusercontent.com/85645967/219462376-170b2ae2-7d14-4068-9d1a-025b54eda94e.mov

cc: @Prince-Mendiratta

Santhosh-Sellavel · 2023-02-16T19:06:26Z

Okay checked other forms seems this is common to all forms not specific to this one.

Santhosh-Sellavel

LGTM tests well!

All you @Beamanator

Prince-Mendiratta · 2023-02-16T19:13:59Z

@Santhosh-Sellavel Thanks for bringing this up, I noticed the weirdness too while I was testing too. Didn't report since the new Date Picker design will fix them anyways. It was important for this PR to at least remove the functionality issue and keep things running while the new date picker is in the works. Can revisit this after the new design is done.

Santhosh-Sellavel · 2023-02-16T20:13:27Z

If you’ve noticed earlier it's always to good bring forward for discussion. This helps speeds things!

Beamanator

Looks great! 👍

OSBotify · 2023-02-20T10:36:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-02-21T21:15:40Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.2.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-02-22T22:58:09Z

🚀 Deployed to production by https://github.com/melvin-bot[bot] in version: 1.2.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Prince-Mendiratta added 3 commits February 9, 2023 23:41

pass date as moment

54631ef

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

set maximum and minimum possible date

4335f39

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

remove moment() conversion for API calls

6e17424

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta requested a review from a team as a code owner February 10, 2023 08:43

melvin-bot bot requested review from Beamanator and Santhosh-Sellavel and removed request for a team February 10, 2023 08:43

Prince-Mendiratta commented Feb 10, 2023

View reviewed changes

Prince-Mendiratta mentioned this pull request Feb 10, 2023

[HOLD for payment 2023-03-01] [$1000] Date error message showing when selecting date far in the past #14936

Closed

6 tasks

use date object

9045636

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Santhosh-Sellavel suggested changes Feb 13, 2023

View reviewed changes

src/pages/ReimbursementAccount/CompanyStep.js Outdated Show resolved Hide resolved

src/pages/ReimbursementAccount/RequestorStep.js Outdated Show resolved Hide resolved

remove unnecessary reassignment

5ef237e

Signed-off-by: Prince Mendiratta <prince.mendi@gmail.com>

Prince-Mendiratta changed the title ~~Date picker~~ fix: moment date conversion for Date Picker in native Feb 13, 2023

Prince-Mendiratta mentioned this pull request Feb 14, 2023

Personal details - Error message displayed when user try to save Date of birth. #15107

Closed

6 tasks

Santhosh-Sellavel approved these changes Feb 16, 2023

View reviewed changes

Beamanator approved these changes Feb 20, 2023

View reviewed changes

Beamanator merged commit c2bfcb5 into Expensify:main Feb 20, 2023

OSBotify mentioned this pull request Feb 21, 2023

Deploy Checklist: New Expensify 2023-02-21 #15329

Closed

19 tasks

Prince-Mendiratta deleted the date-picker branch February 22, 2023 23:24

Prince-Mendiratta changed the title ~~fix: moment date conversion for Date Picker in native~~ [Date Picker] fix: moment date conversion for Date Picker in native May 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Date Picker] fix: moment date conversion for Date Picker in native #15033

[Date Picker] fix: moment date conversion for Date Picker in native #15033

Prince-Mendiratta commented Feb 10, 2023

MelvinBot commented Feb 10, 2023

MelvinBot commented Feb 10, 2023

Prince-Mendiratta Feb 10, 2023

Prince-Mendiratta commented Feb 13, 2023

Santhosh-Sellavel commented Feb 13, 2023 •

edited

Loading

Prince-Mendiratta commented Feb 13, 2023

Beamanator commented Feb 13, 2023

Santhosh-Sellavel commented Feb 13, 2023

Santhosh-Sellavel commented Feb 13, 2023 •

edited

Loading

Santhosh-Sellavel commented Feb 13, 2023

Santhosh-Sellavel commented Feb 15, 2023 •

edited

Loading

Beamanator commented Feb 15, 2023 •

edited

Loading

Prince-Mendiratta commented Feb 15, 2023

Prince-Mendiratta commented Feb 16, 2023

Santhosh-Sellavel commented Feb 16, 2023 •

edited

Loading

Santhosh-Sellavel commented Feb 16, 2023 •

edited

Loading

Santhosh-Sellavel left a comment

Prince-Mendiratta commented Feb 16, 2023

Santhosh-Sellavel commented Feb 16, 2023

Beamanator left a comment

OSBotify commented Feb 20, 2023

OSBotify commented Feb 21, 2023

OSBotify commented Feb 22, 2023

[Date Picker] fix: moment date conversion for Date Picker in native #15033

[Date Picker] fix: moment date conversion for Date Picker in native #15033

Conversation

Prince-Mendiratta commented Feb 10, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Feb 10, 2023

MelvinBot commented Feb 10, 2023

Prince-Mendiratta Feb 10, 2023

Choose a reason for hiding this comment

Prince-Mendiratta commented Feb 13, 2023

Santhosh-Sellavel commented Feb 13, 2023 • edited Loading

Prince-Mendiratta commented Feb 13, 2023

Beamanator commented Feb 13, 2023

Santhosh-Sellavel commented Feb 13, 2023

Santhosh-Sellavel commented Feb 13, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel commented Feb 13, 2023

Santhosh-Sellavel commented Feb 15, 2023 • edited Loading

Beamanator commented Feb 15, 2023 • edited Loading

Prince-Mendiratta commented Feb 15, 2023

Prince-Mendiratta commented Feb 16, 2023

Santhosh-Sellavel commented Feb 16, 2023 • edited Loading

Santhosh-Sellavel commented Feb 16, 2023 • edited Loading

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Prince-Mendiratta commented Feb 16, 2023

Santhosh-Sellavel commented Feb 16, 2023

Beamanator left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 20, 2023

OSBotify commented Feb 21, 2023

OSBotify commented Feb 22, 2023

Santhosh-Sellavel commented Feb 13, 2023 •

edited

Loading

Santhosh-Sellavel commented Feb 13, 2023 •

edited

Loading

Santhosh-Sellavel commented Feb 15, 2023 •

edited

Loading

Beamanator commented Feb 15, 2023 •

edited

Loading

Santhosh-Sellavel commented Feb 16, 2023 •

edited

Loading

Santhosh-Sellavel commented Feb 16, 2023 •

edited

Loading